linux-kernel - Re: [PATCH] ubifs: Use kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j+mJzhzXMg8F+stScfSqcquVofB_D8DHgpbUww8OOs05w@mail.gmail.com>
Date:   Mon, 2 Jul 2018 14:48:00 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Richard Weinberger <richard@....at>
Cc:     Linux mtd <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ubifs: Use kmalloc_array()

On Mon, Jul 2, 2018 at 2:47 PM, Richard Weinberger <richard@....at> wrote:
> Since commit 6da2ec56059c ("treewide: kmalloc() -> kmalloc_array()")
> we use kmalloc_array() for kmalloc() that computes the length with
> a multiplication.
>
> Cc: Kees Cook <keescook@...omium.org>
> Suggested-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Richard Weinberger <richard@....at>

Reviewed-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

> ---
>  fs/ubifs/journal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index eea12d25a58b..95acc0c04bca 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1285,7 +1285,7 @@ static int truncate_data_node(const struct ubifs_info *c, const struct inode *in
>         int err, dlen, compr_type, out_len, old_dlen;
>
>         out_len = le32_to_cpu(dn->size);
> -       buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);
> +       buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);
>         if (!buf)
>                 return -ENOMEM;
>
> --
> 2.18.0
>



-- 
Kees Cook
Pixel Security