linux-kernel - Re: [PATCH][next] gnss: make struct ubx_gserial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180702085933.GG9802@localhost>
Date:   Mon, 2 Jul 2018 10:59:33 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Johan Hovold <johan@...nel.org>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH][next] gnss: make struct ubx_gserial_ops static

On Sat, Jun 30, 2018 at 12:22:46PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The structure ubx_gserial_ops is local to the source and does not need
> to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'ubx_gserial_ops' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

This was reported by the kbuild test robot and an automated RFC patch
submitted was a while back.

I prefer this man-generated one with a proper commit message, so:

Acked-by: Johan Hovold <johan@...nel.org>

> ---
>  drivers/gnss/ubx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c
> index 902b6854b7db..12568aebb7f6 100644
> --- a/drivers/gnss/ubx.c
> +++ b/drivers/gnss/ubx.c
> @@ -59,7 +59,7 @@ static int ubx_set_power(struct gnss_serial *gserial,
>  	return -EINVAL;
>  }
>  
> -const struct gnss_serial_ops ubx_gserial_ops = {
> +static const struct gnss_serial_ops ubx_gserial_ops = {
>  	.set_power = ubx_set_power,
>  };

Thanks,
Johan