linux-kernel - Re: [PATCH] kbuild: check for /sbin/depmod installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQh9jgxTYTUue7j9QjkFmUV-cdLGvMpGhrjivU1km7cWw@mail.gmail.com>
Date:   Mon, 2 Jul 2018 10:23:31 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
        Michal Marek <michal.lkml@...kovi.net>,
        Chih-Wei Huang <cwhuang@...ux.org.tw>
Subject: Re: [PATCH] kbuild: check for /sbin/depmod installed

2018-07-02 2:12 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Verify that 'depmod' ($DEPMOD) is installed.
> This is a partial revert of 620c231c7a7f (from 2012):
>   ("kbuild: do not check for ancient modutils tools")
>
> Fixes kernel bugzilla #198965:
> https://bugzilla.kernel.org/show_bug.cgi?id=198965
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: Chih-Wei Huang <cwhuang@...ux.org.tw>
> Cc: stable@...r.kernel.org # any kernel since 2012
> ---
>  scripts/depmod.sh |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> --- lnx-418-rc2.orig/scripts/depmod.sh
> +++ lnx-418-rc2/scripts/depmod.sh
> @@ -10,10 +10,16 @@ fi
>  DEPMOD=$1
>  KERNELRELEASE=$2
>
> -if ! test -r System.map -a -x "$DEPMOD"; then
> +if ! test -r System.map ; then
>         exit 0
>  fi
>
> +if [ -z $(command -v $DEPMOD) ]; then
> +       echo "'make *install' requires $DEPMOD. Please install it." >&2



I think depmod is required by 'make modules_install'

Is there any reason to make this ambiguous like 'make *install' ?




> +       echo "This is probably in the module-init-tools package." >&2
> +       exit 1
> +fi
> +
>  # older versions of depmod require the version string to start with three
>  # numbers, so we cheat with a symlink here
>  depmod_hack_needed=true
>
>



-- 
Best Regards
Masahiro Yamada