linux-kernel - Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180702101222.GF18211@sirena.org.uk>
Date:   Mon, 2 Jul 2018 11:12:22 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support

On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote:

> +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> +	case SND_SOC_DAIFMT_I2S:
> +	case SND_SOC_DAIFMT_LEFT_J:
> +		break;

These two modes are not the same so either there should be some
different handling to select between them or one shouldn't be supported.

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)