linux-kernel - Re: [PATCH] iio: dac: remove redundant variable 'shift'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62141c55-575a-d068-360a-e0ea53df6f17@prevas.dk>
Date:   Mon, 2 Jul 2018 12:43:20 +0200
From:   Sean Nyekjær <sean.nyekjaer@...vas.dk>
To:     Colin King <colin.king@...onical.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: remove redundant variable 'shift'



On 2018-07-02 12:24, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable shift is being assigned but is never used hence it is
> redundant and can be removed.
> 
> Cleans up two clang warnings:
> warning: variable ‘shift’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Reviewed-by: Sean Nyekjaer <sean.nyekjaer@...vas.dk>

Good catch :-)

BR
/Sean