linux-kernel - Re: [PATCH] watchdog: change ITCO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2029ee35-c1c6-86ab-8986-2d79eb5b4d8c@roeck-us.net>
Date:   Mon, 2 Jul 2018 06:16:49 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Tian, Baofeng" <baofeng.tian@...el.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] watchdog: change ITCO_WDT type from tristate to bool

On 07/02/2018 01:18 AM, Tian, Baofeng wrote:
> From: "Tian, Baofeng" <baofeng.tian@...el.com <mailto:baofeng.tian@...el.com>>
> Subject: [PATCH] watchdog: change ITCO_WDT type from tristate to bool
> 
> tristate will allow kernel config it to M and build ko file,
> this will cause build allmodconfig errors as necessary
> symbols have not been exported.
> change it to bool, only allow config ITCO_WDT to yes/no.
> 
> Signed-off-by: Tian, Baofeng <baofeng.tian@...el.com <mailto:baofeng.tian@...el.com>>

This works today. I don't see a point changing it, and I am wary doing so.
There are systems where the iTCO watchdog doesn't work (I own one of those),
even though it instantiates, and I am wary of force-loading it.

Besides, you don't explain which "necessary symbols have not been exported".
I do not plan to spend time trying to find out what those symbols are, and
why this would suddenly be a problem.

Guenter

> ---
>   drivers/watchdog/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9af07fd..f991e93 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1049,7 +1049,7 @@ config INTEL_MID_WATCHDOG
>          To compile this driver as a module, choose M here.
> 
>   config ITCO_WDT
> -     tristate "Intel TCO Timer/Watchdog"
> +     bool "Intel TCO Timer/Watchdog"
>        depends on (X86 || IA64) && PCI
>        select WATCHDOG_CORE
>        depends on I2C || I2C=n
> -- 
> 2.7.4
>