linux-kernel - Re: [PATCH V3 0/4] Changes for SDCC5 version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Jul 2018 15:17:21 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Vijay Viswanath <vviswana@...eaurora.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Georgi Djakov <georgi.djakov@...aro.org>,
        devicetree@...r.kernel.org, Asutosh Das <asutoshd@...eaurora.org>,
        Sahitya Tummala <stummala@...eaurora.org>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        Jeremy McNicoll <jeremymc@...hat.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Harjani Ritesh <riteshh@...eaurora.org>,
        vbadigan@...eaurora.org, Doug Anderson <dianders@...gle.com>,
        sayalil@...eaurora.org
Subject: Re: [PATCH V3 0/4] Changes for SDCC5 version

On 19 June 2018 at 07:39, Vijay Viswanath <vviswana@...eaurora.org> wrote:
> With SDCC5, the MCI register space got removed and the offset/order of
> several registers have changed. Based on SDCC version used and the register,
> we need to pick the base address and offset.
>
> Depends on patch series: "[PATCH V5 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm"
>
> Changes since RFC:
>         Dropped voltage regulator changes in sdhci-msm
>         Split the "Register changes for sdcc V5" patch
>         Instead of checking mci removal for deciding which base addr to use,
>         new function pointers are defined for the 2 variants of sdcc:
>                 1) MCI present
>                 2) V5 (mci removed)
>         Instead of string comparing with the compatible string from DT file,
>         the sdhci_msm_probe will now pick the data associated with the
>         compatible entry and use it to load variant specific address offsets
>         and msm variant specific read/write ops.
>
> Changes since V1:
>         Removed unused msm_reab & msm_writeb APIs
>         Changed certain register addresses from uppercase to lowercase hex
>         letters
>         Removed extra lines and spaces
>         Split "[PATCH V1 0/3] Changes for SDCC5 version" patch into two,
>         one for Documentation and other for the driver changes.
>
> Changes since V2:
>         Used lower case for macro function defenitions
>         Removed unused function pointers for msm_readb & msm_writeb
>
>
> Sayali Lokhande (3):
>   mmc: sdhci-msm: Define new Register address map
>   Documentation: sdhci-msm: Add new compatible string for SDCC v5
>   mmc: host: Register changes for sdcc V5
>
> Vijay Viswanath (1):
>   mmc: sdhci-msm: Add msm version specific ops and data structures
>
>  .../devicetree/bindings/mmc/sdhci-msm.txt          |   7 +-
>  drivers/mmc/host/sdhci-msm.c                       | 511 ++++++++++++++++-----
>  2 files changed, 391 insertions(+), 127 deletions(-)
>

Thanks, applied for next!

Kind regards
Uffe