linux-kernel - Re: [PATCH] venus: venc: add support for ext controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201807022329.YBsiWZ5k%fengguang.wu@intel.com>
Date:   Mon, 2 Jul 2018 23:39:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vikash Garodia <vgarodia@...eaurora.org>
Cc:     kbuild-all@...org, stanimir.varbanov@...aro.org,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, acourbot@...omium.org,
        vgarodia@...eaurora.org
Subject: Re: [PATCH] venus: venc: add support for ext controls

Hi Vikash,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.18-rc3 next-20180702]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vikash-Garodia/venus-venc-add-support-for-ext-controls/20180702-213140
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers/media/platform/qcom/venus/venc.c:653:3: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_s_ext_ctrl'; did you mean 'vidioc_s_ext_ctrls'?
     .vidioc_s_ext_ctrl = venc_s_ext_ctrls,
      ^~~~~~~~~~~~~~~~~
      vidioc_s_ext_ctrls
>> drivers/media/platform/qcom/venus/venc.c:653:23: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     .vidioc_s_ext_ctrl = venc_s_ext_ctrls,
                          ^~~~~~~~~~~~~~~~
   drivers/media/platform/qcom/venus/venc.c:653:23: note: (near initialization for 'venc_ioctl_ops')
>> drivers/media/platform/qcom/venus/venc.c:653:23: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
   drivers/media/platform/qcom/venus/venc.c:653:23: note: (near initialization for 'venc_ioctl_ops.vidioc_try_fmt_vid_out_mplane')
   cc1: some warnings being treated as errors

vim +653 drivers/media/platform/qcom/venus/venc.c

   629	
   630	static const struct v4l2_ioctl_ops venc_ioctl_ops = {
   631		.vidioc_querycap = venc_querycap,
   632		.vidioc_enum_fmt_vid_cap_mplane = venc_enum_fmt,
   633		.vidioc_enum_fmt_vid_out_mplane = venc_enum_fmt,
   634		.vidioc_s_fmt_vid_cap_mplane = venc_s_fmt,
   635		.vidioc_s_fmt_vid_out_mplane = venc_s_fmt,
   636		.vidioc_g_fmt_vid_cap_mplane = venc_g_fmt,
   637		.vidioc_g_fmt_vid_out_mplane = venc_g_fmt,
   638		.vidioc_try_fmt_vid_cap_mplane = venc_try_fmt,
   639		.vidioc_try_fmt_vid_out_mplane = venc_try_fmt,
   640		.vidioc_g_selection = venc_g_selection,
   641		.vidioc_s_selection = venc_s_selection,
   642		.vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
   643		.vidioc_querybuf = v4l2_m2m_ioctl_querybuf,
   644		.vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
   645		.vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
   646		.vidioc_qbuf = v4l2_m2m_ioctl_qbuf,
   647		.vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
   648		.vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
   649		.vidioc_streamon = v4l2_m2m_ioctl_streamon,
   650		.vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
   651		.vidioc_s_parm = venc_s_parm,
   652		.vidioc_g_parm = venc_g_parm,
 > 653		.vidioc_s_ext_ctrl = venc_s_ext_ctrls,
   654		.vidioc_enum_framesizes = venc_enum_framesizes,
   655		.vidioc_enum_frameintervals = venc_enum_frameintervals,
   656		.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
   657		.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
   658	};
   659	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (64133 bytes)