linux-kernel - Re: [PATCH] kvmclock: remove redundant variable 'size'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36bf55ec-1937-6c3c-49fc-329a1309a815@oracle.com>
Date:   Mon, 2 Jul 2018 16:57:43 +0100
From:   Liam Merwick <liam.merwick@...cle.com>
To:     Colin King <colin.king@...onical.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kvm@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvmclock: remove redundant variable 'size'



On 02/07/18 08:06, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable size is being assigned but is never used hence it is redundant
> and can be removed.
> 
> Cleans up clang warning:
> warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
> 

Is it worth adding

Fixes: cc1e24fdb064 ("x86/vdso: Remove pvclock fixmap machinery")

> Signed-off-by: Colin Ian King <colin.king@...onical.com>

either way

Reviewed-by: Liam Merwick <liam.merwick@...cle.com>

> ---
>   arch/x86/kernel/kvmclock.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index bf8d1eb7fca3..45c22ce941c1 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -354,13 +354,10 @@ int __init kvm_setup_vsyscall_timeinfo(void)
>   	int cpu;
>   	u8 flags;
>   	struct pvclock_vcpu_time_info *vcpu_time;
> -	unsigned int size;
>   
>   	if (!hv_clock)
>   		return 0;
>   
> -	size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
> -
>   	cpu = get_cpu();
>   
>   	vcpu_time = &hv_clock[cpu].pvti;
>