linux-kernel - Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d884aed7-6c64-5e83-243b-e6ca6be543a0@amd.com>
Date:   Mon, 2 Jul 2018 11:34:24 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Janakarajan Natarajan <Janakarajan.Natarajan@....com>,
        x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     brijesh.singh@....com, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at
 minimum matches KVM_AMD



On 06/27/2018 11:30 AM, Janakarajan Natarajan wrote:
> Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
> that AMD Secure Processor device driver will be built-in when KVM_AMD is
> also built-in.
> 
> v1->v2:
> * Removed usage of 'imply' Kconfig option.
> * Change patch commit message.
> 
> Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")
> 
> Cc: <stable@...r.kernel.org> # 4.16.x
> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@....com>
> ---

Reviewed-by: Brijesh Singh <brijesh.singh@....com>


>   arch/x86/kvm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 92fd433..1bbec38 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -85,7 +85,7 @@ config KVM_AMD_SEV
>   	def_bool y
>   	bool "AMD Secure Encrypted Virtualization (SEV) support"
>   	depends on KVM_AMD && X86_64
> -	depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
> +	depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
>   	---help---
>   	Provides support for launching Encrypted VMs on AMD processors.
>   
>