linux-kernel - Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180702182434.5wxxszpgpf6wergl@ninjato>
Date:   Mon, 2 Jul 2018 20:24:34 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Eddie James <eajames@...ux.vnet.ibm.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        benh@...nel.crashing.org, joel@....id.au, mark.rutland@....com,
        gregkh@...uxfoundation.org, rdunlap@...radead.org,
        andy.shevchenko@...il.com, peda@...ntia.se
Subject: Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation


> > > +	if (msg->flags & I2C_M_RD)
> > > +		cmd |= I2C_CMD_READ;
> > Since you support MANGLING, I'd think you can easily support
> > I2C_M_REV_DIR_ADDR here, too?
> 
> Hm, I don't really understand the purpose of that flag. From the docs:
> 
> This toggles the Rd/Wr flag. That is, if you want to do a write, but
>     need to emit an Rd instead of a Wr, or vice versa, you set this
>     flag. For example:
> S Addr Rd [A] Data [A] Data [A] ... [A] Data [A] P
> 
> I don't think our hardware supports this type of operation.

I'd think something like this should do:

	if (msg->flags & I2C_M_REV_DIR_ADDR)
		cmd ^= I2C_CMD_READ;


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)