linux-kernel - Re: [PATCH v2 4/6] mm/fs: add a sync_mode param for clear_page_dirty_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddf3ac95-ce47-41a8-b94b-c7a3d016700f@nvidia.com>
Date:   Sun, 1 Jul 2018 21:40:17 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     kbuild test robot <lkp@...el.com>, <john.hubbard@...il.com>
CC:     <kbuild-all@...org>, Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...nel.org>,
        Christopher Lameter <cl@...ux.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Dan Williams <dan.j.williams@...el.com>,
        Jan Kara <jack@...e.cz>, <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v2 4/6] mm/fs: add a sync_mode param for
 clear_page_dirty_for_io()

On 07/01/2018 07:11 PM, kbuild test robot wrote:
> Hi John,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.18-rc3]
> [cannot apply to next-20180629]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125
> config: x86_64-randconfig-x010-201826 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
[...]
>                                             ^
>    include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
>                                              ^~~~
>>> fs/f2fs/data.c:2021:4: note: in expansion of macro 'if'
>        if (!clear_page_dirty_for_io(page), wbc->sync_mode)
>        ^~
>    fs/f2fs/data.c:2021:9: error: too few arguments to function 'clear_page_dirty_for_io'
>        if (!clear_page_dirty_for_io(page), wbc->sync_mode)
>             ^
>    include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
>       ______r = !!(cond);     \
>                    ^~~~
>>> fs/f2fs/data.c:2021:4: note: in expansion of macro 'if'
>        if (!clear_page_dirty_for_io(page), wbc->sync_mode)
>        ^~

> 

Typo, that should have been:
         if (!clear_page_dirty_for_io(page, wbc->sync_mode))

...fixed locally, I'll include it in the next spin. (Somehow my last build didn't
have all the filesystems enabled, sorry for the glitches.)
   

thanks,
-- 
John Hubbard
NVIDIA