lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f16a7de43b151c6f98ff5ff379427f16@pados.hu>
Date:   Mon, 02 Jul 2018 19:17:33 +0000
From:   "Karoly Pados" <pados@...os.hu>
To:     "Bjørn Mork" <bjorn@...k.no>,
        "Johan Hovold" <johan@...nel.org>
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Martyn Welch" <martyn.welch@...labora.co.uk>
Subject: Re: [PATCH] USB: serial: cp210x: Implement GPIO support for
 CP2102N

>> First of all I can't seem to find that code snippet on the wiki page it
>> does refer to, so I'm still not convinced.
> 
> It was there in older versions of the article. See for example:
> https://en.wikipedia.org/w/index.php?title=Fletcher's_checksum&oldid=730327006
> 
>> Second, this should have been high-lighted in your submission somehow.
> 
> Definitely. All code has an original author who deserves credit. And if
> you cannot find the original author, then there is always a risk than
> someone along the line stole the code... Maybe long before it ended up
> in Wikipedia. But that doesn't matter.
> 
> Doesn't seem worth the risk for a simple checksum algorithm which
> probably has lots of GPL implementations.
> 

Sorry about not explicitly mentioning the source, I only cared about making
sure that there is no violation and I thought that'd be enough.
Next time something like this happens, I'll explicitly name the sources
even if the license does not require it.

And just to clear things up further, rest assured that fletcher function was 
the only one copied from the Cypress knowledge base or from anywhere else.
Rest is by me, so there should be no other unclear origins.

On a different note, v2 patches are coming soon with the feedback from Johan
incorporated. Did not forget and I still intend to polish everything up
as requested to get these features into mainline.

Karoly

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ