linux-kernel - Re: [PATCH v2 1/4] iio: hx711: add data-ready-delay-ns property in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180703214843.GA484@rob-hp-laptop>
Date:   Tue, 3 Jul 2018 15:48:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Andreas Klinger <ak@...klinger.de>, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, mark.rutland@....com,
        mchehab@...nel.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        linus.walleij@...aro.org, rdunlap@...radead.org,
        devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] iio: hx711: add data-ready-delay-ns property in DT

On Sat, Jun 30, 2018 at 06:32:32PM +0100, Jonathan Cameron wrote:
> On Mon, 25 Jun 2018 17:18:02 +0200
> Andreas Klinger <ak@...klinger.de> wrote:
> 
> > add data-ready-delay-ns property for hx711 ADC
> > this is the delay after rising PD_SCK until DOUT is read and assumed to be
> > ready
> > 
> > Signed-off-by: Andreas Klinger <ak@...klinger.de>
> 
> Hmm. It's not particularly generic... I think this should have
> have vendor prefix until we have some visibility of whether it
> is a common thing we want to standardise around or not.

Agreed. Doesn't look like any interface I've seen before.

Since it's bit-banging, seems to me it would be better to specify the 
frequency for PD_SCK and sample DOUT just before or after setting PD_SCK 
low. 

Rob

> I'll also be waiting for a devicetree ack on this one as it's a
> tiny bit unusual.
> 
> Thanks,
> 
> Jonathan