linux-kernel - Re: [PATCH 10/32] VFS: Implement a filesystem superblock creation/configuration context [ver #8]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703215825.GX30522@ZenIV.linux.org.uk>
Date:   Tue, 3 Jul 2018 22:58:26 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     David Howells <dhowells@...hat.com>
Cc:     Eric Biggers <ebiggers3@...il.com>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-afs@...ts.infradead.org
Subject: Re: [PATCH 10/32] VFS: Implement a filesystem superblock
 creation/configuration context [ver #8]

On Tue, Jul 03, 2018 at 10:53:22PM +0100, David Howells wrote:
> -				if (s) {
> -					up_write(&s->s_umount);
> +				if (s)
>  					destroy_unused_super(s);

static void destroy_unused_super(struct super_block *s)
{
        if (!s)
                return;
	...
}

IOW, all of those should be unconditional.