linux-kernel - Re: [PATCH] bus: ti-sysc: Use 2-factor allocator arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180703062007.GA112168@atomide.com>
Date:   Mon, 2 Jul 2018 23:20:07 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] bus: ti-sysc: Use 2-factor allocator arguments

* Kees Cook <keescook@...omium.org> [180702 16:17]:
> On Mon, Jul 2, 2018 at 4:27 AM, Tony Lindgren <tony@...mide.com> wrote:
> > * Kees Cook <keescook@...omium.org> [180627 21:59]:
> >> On Mon, Jun 18, 2018 at 10:45 AM, Kees Cook <keescook@...omium.org> wrote:
> >> > This adjusts the allocator calls to use 2-factor argument call style, as
> >> > done treewide already for improved defense against allocation overflows.
> >> >
> >> > Signed-off-by: Kees Cook <keescook@...omium.org>
> >>
> >> Friendly ping! :) This is the last 2-factor devm* allocation left in
> >> 4.18 to be fixed.
> >
> > Sorry for the delay on this one. As we're already at -rc3, I'll apply
> > this into omap-for-v4.19/ti-sysc. Seems there should not be need to rush
> > this into v4.18-rc cycle, but please do let me know if that is not the
> > case.
> 
> I'd like to be able to reason about multiplication vs allocator uses
> in 4.18 and later. Since all other allocators got fixed in 4.18, I'd
> really like to have this one fixed too, then the scripts that check
> for multiplications in single-argument allocators will run clean for
> 4.18.
> 
> So, it's not strictly a "rush", but it would be appreciated. :)

OK I'll merge that commit also into omap-for-v4.18/fixes branch
too.

Regards,

Tony