linux-kernel - Re: [PATCH] selftests: bpf: config: add config fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Jul 2018 12:51:38 +0200
From:   Anders Roxell <anders.roxell@...aro.org>
To:     William Tu <u9012063@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH] selftests: bpf: config: add config fragments

On Tue, 26 Jun 2018 at 23:27, William Tu <u9012063@...il.com> wrote:
>
> >> >
> >> > --- ::11 ping statistics ---
> >> > 5 packets transmitted, 3 packets received, 40% packet loss
> >> > round-trip min/avg/max = 0.139/1.857/5.293 ms
> >> > + ip netns exec at_ns0 ping -c 3 -w 10 -q 10.1.1.200
> >> > PING 10.1.1.200 (10.1.1.200): 56 data bytes
> >> >
> >> > --- 10.1.1.200 ping statistics ---
> >> > 3 packets transmitted, 3 packets received, 0% packet loss
> >> > round-trip min/avg/max = 0.214/0.256/0.305 ms
> >> > + ping -c 3 -w 10 -q 10.1.1.100
> >> > PING 10.1.1.100 (10.1.1.100): 56 data bytes
> >> >
> >> > --- 10.1.1.100 ping statistics ---
> >> > 3 packets transmitted, 3 packets received, 0% packet loss
> >> > round-trip min/avg/max = 0.210/0.211/0.213 ms
> >> > + check_err 0
> >> > + '[' 0 -eq 0 ']'
> >> > + ret=0
>
> So looks like the ipv4 over ipv6 gre passes.
>
> >> > + ip netns exec at_ns0 ping6 -c 3 -w 10 -q fc80::200
> >> > PING fc80::200 (fc80::200): 56 data bytes
> >> >
> >> > --- fc80::200 ping statistics ---
> >> > 10 packets transmitted, 0 packets received, 100% packet loss
> `
> but the ipv6 over ipv6 gre fails.
> Do you have any firewall rules that block this traffic?
> or if possible, the packet might get dropped at function ip6gre_xmit_ipv6
> can you print the return value of this function?
>
>
> >> > + check_err 1
> >> > + '[' 0 -eq 0 ']'
> >> > + ret=1
> >> > + ip -s link show ip6gretap11
> >> > 19: ip6gretap11@...E: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1434 qdisc
> >> > pfifo_fast state UNKNOWN mode DEFAULT group default qlen 1000
> >> >     link/ether de:d2:0c:53:80:8c brd ff:ff:ff:ff:ff:ff
> >> >     RX: bytes  packets  errors  dropped overrun mcast
> >> >     2096       25       0       0       0       0
> >> >     TX: bytes  packets  errors  dropped carrier collsns
> >> >     5324       36       5       5       0       0
> >>
> >> So there are 5 errors at TX.
> >
> > and today when I tried it on next-20180620 I saw 8 errors at TX.
> >
> >> I couldn't reproduce in my local machine using 4.17-rc6.
> >> How do I checkin the "next-20180613" source code?
> >
> > You can find the source code here [1], and I would look in the latest tag that I
> > said that I was able to reproduce it on above.
> >
> > Cheers,
> > Anders
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/
>
> Hi Anders,

Hi William,

>
> I'm still not able to reproduce the issue on next-20180620.

I'm not able to reproduce it either, and I tried on todays tag as well
next-20180703.

The only test that is failing in bpf/test_tunnel.sh:

FAIL: xfrm tunnel

Cheers,
Anders

> Below is my test.
>
> Testing IP6GRETAP tunnel...
> PING ::11(::11) 56 data bytes
>
> --- ::11 ping statistics ---
> 5 packets transmitted, 3 received, 40% packet loss, time 4048ms
> rtt min/avg/max/mdev = 0.040/32.118/96.235/45.337 ms
> PING 10.1.1.200 (10.1.1.200) 56(84) bytes of data.
>
> --- 10.1.1.200 ping statistics ---
> 3 packets transmitted, 3 received, 0% packet loss, time 2026ms
> rtt min/avg/max/mdev = 0.074/0.099/0.117/0.018 ms
> PING 10.1.1.100 (10.1.1.100) 56(84) bytes of data.
>
> --- 10.1.1.100 ping statistics ---
> 3 packets transmitted, 3 received, 0% packet loss, time 2054ms
> rtt min/avg/max/mdev = 0.069/0.113/0.187/0.052 ms
> PING fc80::200(fc80::200) 56 data bytes
>
> --- fc80::200 ping statistics ---
> 3 packets transmitted, 3 received, 0% packet loss, time 2054ms
> rtt min/avg/max/mdev = 0.069/0.104/0.142/0.031 ms
> PASS: ip6gretap
> root@...oxes:~/linux-next/tools/testing/selftests/bpf#
> root@...oxes:~/linux-next/tools/testing/selftests/bpf# uname -a
> Linux osboxes 4.18.0-rc1-next-20180620 #1 SMP Tue Jun 26 12:26:00 PDT
> 2018 x86_64 x86_64 x86_64 GNU/Linux