linux-kernel - Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfe24a3b-c982-9532-c05b-f42ebb77bbba@gmail.com>
Date:   Tue, 3 Jul 2018 09:55:18 +0800
From:   Jia He <hejianet@...il.com>
To:     Pavel Tatashin <pasha.tatashin@...cle.com>
Cc:     linux@...linux.org.uk, Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Mel Gorman <mgorman@...e.de>, will.deacon@....com,
        mark.rutland@....com, hpa@...or.com,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        AKASHI Takahiro <takahiro.akashi@...aro.org>,
        Gioh Kim <gi-oh.kim@...fitbricks.com>,
        Steven Sistare <steven.sistare@...cle.com>, neelx@...hat.com,
        erosca@...adit-jv.com, Vlastimil Babka <vbabka@...e.cz>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        james.morse@....com, ard.biesheuvel@...aro.org,
        steve.capper@....com, tglx@...utronix.de, mingo@...hat.com,
        gregkh@...uxfoundation.org, kstewart@...uxfoundation.org,
        pombredanne@...b.com, Johannes Weiner <hannes@...xchg.org>,
        kemi.wang@...el.com, ptesarik@...e.com, yasu.isimatu@...il.com,
        aryabinin@...tuozzo.com, nborisov@...e.com,
        Wei Yang <richard.weiyang@...il.com>, jia.he@...-semitech.com
Subject: Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn()
 on arm/arm64

Hi, Pavel
Thanks for the comments.

On 6/30/2018 2:13 AM, Pavel Tatashin Wrote:
>> +++ b/include/linux/early_pfn.h
>> @@ -0,0 +1,34 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/* Copyright (C) 2018 HXT-semitech Corp. */
>> +#ifndef __EARLY_PFN_H
>> +#define __EARLY_PFN_H
>> +#ifdef CONFIG_HAVE_MEMBLOCK_PFN_VALID
>> +ulong __init_memblock memblock_next_valid_pfn(ulong pfn)
>> +{
>> +       struct memblock_type *type = &memblock.memory;
> 
> Why put it in a header file and not in some C file? In my opinion it
> is confusing to have non-line functions in header files. Basically,
> you can include this header file in exactly one C file without
> breaking compilation.
> 
My original intent is to make this helper memblock_next_valid_pfn
a common api between arm64 and arm arches since both arches will
use enable CONFIG_HAVE_MEMBLOCK_PFN_VALID by default.

Do you think it looks ok if I add the inline prefix?

-- 
Cheers,
Jia