linux-kernel - Re: [PATCH] refcount: always allow checked forms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703113934.d2c5grjqwq5kuk4h@lakrids.cambridge.arm.com>
Date:   Tue, 3 Jul 2018 12:39:35 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Andrea Parri <andrea.parri@...rulasolutions.com>
Cc:     linux-kernel@...r.kernel.org, Boqun Feng <boqun.feng@...il.com>,
        David Sterba <dsterba@...e.com>,
        Ingo Molnar <mingo@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCH] refcount: always allow checked forms

On Tue, Jul 03, 2018 at 12:33:20PM +0200, Andrea Parri wrote:
> Hi Mark,
> 
> a typo below:
> 
> 
> >  /**
> > - * refcount_inc - increment a refcount
> > + * refcount_inc_checked - increment a refcount
> >   * @r: the refcount to increment
> >   *
> >   * Similar to atomic_inc(), but will saturate at UINT_MAX and WARN.
> > @@ -148,14 +146,14 @@ EXPORT_SYMBOL(refcount_inc_not_zero);
> >   * Will WARN if the refcount is 0, as this represents a possible use-after-free
> >   * condition.
> >   */
> > -void refcount_inc(refcount_t *r)
> > +void refcount_inc_chcked(refcount_t *r)
> 
> s/chcked/checked

The kbuild test robot also just spotted this; I've fixed tht up locally
and pushed it out to my atomics/refcount-checked branch.

Thanks for the spot!

Mark.