linux-kernel - Re: [PATCH 0/2] serial: 8250_dw: add fractional divisor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9bf4c643f51ab222dbc0221acc47773ee3d1a9a.camel@linux.intel.com>
Date:   Tue, 03 Jul 2018 16:03:40 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/2] serial: 8250_dw: add fractional divisor support

On Tue, 2018-07-03 at 10:48 +0800, Jisheng Zhang wrote:
> On Tue, 3 Jul 2018 10:22:57 +0800 Jisheng Zhang wrote:

> patching struct uart_port seems a bit overhead. After reading the code
> again, I propose another solution, similar as what dl_write() is used
> in
> 8250 core:
> 
> 1.introduce the hook to struct uart_8250_port as my previous patches
> do, 
> 
> 2.rename current serial8250_set_divisor() as
> default_serial_get_divisor()
> then introduce a new serial8250_set_divisor() as:
> static inline void serial8250_set_divisor(struct uart_8250_port
> *up,....)
> {
> 	up->set_divisor();
> }
> 
> and point up->set-divisor to default_serial_get_divisor
> 
> what do you think about this solution?

Disagree. See my previous answer for details.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy