linux-kernel - Re: [PATCH 2/3] m68k/page_no.h: force _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703142054.GL16767@dhcp22.suse.cz>
Date:   Tue, 3 Jul 2018 16:20:54 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Mike Rapoport <rppt@...ux.vnet.ibm.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Sam Creasey <sammy@...my.net>, linux-m68k@...ts.linux-m68k.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] m68k/page_no.h: force __va argument to be unsigned
 long

On Tue 03-07-18 13:29:54, Mike Rapoport wrote:
> Add explicit casting to unsigned long to the __va() parameter

Why is this needed?

> Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> ---
>  arch/m68k/include/asm/page_no.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h
> index e644c4d..6bbe520 100644
> --- a/arch/m68k/include/asm/page_no.h
> +++ b/arch/m68k/include/asm/page_no.h
> @@ -18,7 +18,7 @@ extern unsigned long memory_end;
>  #define __HAVE_ARCH_ALLOC_ZEROED_USER_HIGHPAGE
>  
>  #define __pa(vaddr)		((unsigned long)(vaddr))
> -#define __va(paddr)		((void *)(paddr))
> +#define __va(paddr)		((void *)((unsigned long)(paddr)))
>  
>  #define virt_to_pfn(kaddr)	(__pa(kaddr) >> PAGE_SHIFT)
>  #define pfn_to_virt(pfn)	__va((pfn) << PAGE_SHIFT)
> -- 
> 2.7.4

-- 
Michal Hocko
SUSE Labs