linux-kernel - Re: [PATCH] selinux: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhTRmWnobxqjffSwvUQfjOP0mo-qOVF_CAd5po_8tGpR5A@mail.gmail.com>
Date:   Mon, 2 Jul 2018 22:41:10 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     joe@...ches.com
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>, peter.enderborg@...y.com,
        selinux@...ho.nsa.gov, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selinux: Use pr_fmt to prefix "SELinux: "

On Mon, Jul 2, 2018 at 10:10 PM Joe Perches <joe@...ches.com> wrote:
> On Mon, 2018-07-02 at 21:15 -0400, Paul Moore wrote:
> > On Mon, Jul 2, 2018 at 5:31 PM Joe Perches <joe@...ches.com> wrote:
> > > On Mon, 2018-07-02 at 16:51 -0400, Paul Moore wrote:
> > > > On Wed, Jun 20, 2018 at 2:39 AM Joe Perches <joe@...ches.com> wrote:
> > > > > pr_fmt can be used with the pr_<level> macros to prefix
> > > > > arbitrary content to logging messages.
> > > > >
> > > > > So add '#define pr_fmt(fmt) "SELinux: " fmt' to selinux files
> > > > > that use pr_<level> and remove embedded "SELinux: " prefixes
> > > > > from the format strings.
> > > []
> > > > What tree did you base your patch on?
> > >
> > > next-20180619 on the day it was sent.
> > >
> > > > Please base SELinux patches
> > > > either on the SELinux tree or Linus' tree.  The SELinux tree can be
> > > > found at the links below:
> > > >
> > > > * git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
> > > > * https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
> > >
> > > It's almost always better to use selinux/next.
> > > Why should this patch be different?
> >
> > Yes, that's what I said, please base your patch against the selinux/next branch.
>
> Again, this patch was based on that branch on the date the
> patch was sent.
>
> It still applies today to -next.

It doesn't apply cleanly to the selinux/next branch, I believe because
there are other trees which have made changes under security/selinux/*
(I believe there was some fs related work from David Howells that
touched some SELinux/LSM code).

As I said earlier, if you want me to apply your patches to the SELinux
tree, please base them either against the selinux/next tree or against
Linus' tree.

-- 
paul moore
www.paul-moore.com