linux-kernel - Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Jul 2018 23:03:01 -0400
From:   Pavel Tatashin <pasha.tatashin@...cle.com>
To:     Jia He <hejianet@...il.com>
Cc:     linux@...linux.org.uk, Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Mel Gorman <mgorman@...e.de>, will.deacon@....com,
        mark.rutland@....com, hpa@...or.com,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        AKASHI Takahiro <takahiro.akashi@...aro.org>,
        Gioh Kim <gi-oh.kim@...fitbricks.com>,
        Steven Sistare <steven.sistare@...cle.com>, neelx@...hat.com,
        erosca@...adit-jv.com, Vlastimil Babka <vbabka@...e.cz>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        james.morse@....com, Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        steve.capper@....com, tglx@...utronix.de, mingo@...hat.com,
        gregkh@...uxfoundation.org,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Johannes Weiner <hannes@...xchg.org>, kemi.wang@...el.com,
        Petr Tesařík <ptesarik@...e.com>,
        yasu.isimatu@...il.com, aryabinin@...tuozzo.com, nborisov@...e.com,
        Wei Yang <richard.weiyang@...il.com>, jia.he@...-semitech.com
Subject: Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn()
 on arm/arm64

Can you put it into memblock.c

> Do you think it looks ok if I add the inline prefix?

I would say no, this function is a too complex, and is not in some
critical path to be always inlined.

 I would put it into memblock.c, and have #ifdef
CONFIG_HAVE_MEMBLOCK_PFN_VALID around it.

Thank you,
Pavel