linux-kernel - Re: [PATCH v4 0/5] bitmap: Introduce alloc/free helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Jul 2018 00:30:06 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...hat.com>,
        device-mapper development <dm-devel@...hat.com>,
        Shaohua Li <shli@...nel.org>, linux-raid@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input <linux-input@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Yury Norov <ynorov@...iumnetworks.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v4 0/5] bitmap: Introduce alloc/free helpers

On Sat, Jun 30, 2018 at 11:17 PM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> A lot of code is using allocation of bitmaps using BITS_PER_LONG() macro and
> sizeof(unsigned long) operator. The readability suffers because of this.
>
> The series introduces three helpers, i.e. bitmap_alloc(), bitmap_zalloc() and
> bitmap_free(), to make it more cleaner.
>

Dmitry, it seems we are all set now and if you have no objections
against this version, it would be nice to see it in your tree followed
by upstream.

> Patches 1 and 2 are preparatory to avoid namespace collisions between
> bitmap API and DM / MD bitmap. No functional changes intended.
>
> Patch 3 introduces new helpers.
>
> Patches 4 and 5 is just an example how to use new helpers. Locally I have
> like dozen of them against different subsystems and drivers.
>
> Taking above into consideration it might make sense to have
> an immutable branch for this cycle.
>
> Ideally it would go through Input subsystem, thus, needs an Ack
> from MD / DM maintainer(s).
>
> Since v3:
> - split DM part and do rename accordingly (Mike)
> - explain better in the commit message why we can't make helpers as
>   inliners (Dmitry, Andrew)
> - drop applied orphaned patch
>
> Since v2:
> - fix compilation issue in MD bitmap code
> - elaborate changes in commit message of patch 5
>
> Since v1:
> - added namespace fix patch against MD bitmap API
> - moved functions to lib/bitmap.c to avoid circular dependencies
> - appended Dmitry's tags
>
> Andy Shevchenko (5):
>   dm: Avoid namespace collision with bitmap API
>   md: Avoid namespace collision with bitmap API
>   bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()
>   Input: gpio-keys - Switch to bitmap_zalloc()
>   Input: evdev - Switch to bitmap API
>
>  drivers/input/evdev.c                         |  16 +-
>  drivers/input/keyboard/gpio_keys.c            |   8 +-
>  drivers/md/dm-raid.c                          |   6 +-
>  drivers/md/md-bitmap.c                        | 305 +++++++++---------
>  drivers/md/md-bitmap.h                        |  60 ++--
>  drivers/md/md-cluster.c                       |  18 +-
>  drivers/md/md.c                               |  44 +--
>  .../md/persistent-data/dm-space-map-common.c  |  20 +-
>  drivers/md/raid1.c                            |  35 +-
>  drivers/md/raid10.c                           |  52 ++-
>  drivers/md/raid5-cache.c                      |   8 +-
>  drivers/md/raid5.c                            |  44 +--
>  include/linux/bitmap.h                        |   8 +
>  lib/bitmap.c                                  |  19 ++
>  14 files changed, 326 insertions(+), 317 deletions(-)
>
> --
> 2.18.0
>



-- 
With Best Regards,
Andy Shevchenko