linux-kernel - RE: [PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704005918epcms1p6c43766664c42fac3ee4d7eb7375b43eb@epcms1p6>
Date:   Wed, 04 Jul 2018 09:59:18 +0900
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kernel@...labora.com" <kernel@...labora.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: RE: [PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers
 are built as modules.

>+		if (!strncmp(name, DEVFREQ_GOV_SIMPLE_ONDEMAND,
>+			     DEVFREQ_NAME_LEN))
>+			err = request_module("governor_%s", "simpleondemand");
>+		else
>+			err = request_module("governor_%s", name);
>+		if (err)
>+			return NULL;

You are returning without the lock acquired..