linux-kernel - Re: [PATCH v2] leds: ledtrig-morse: send out morse code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704065305.GA23509@amd>
Date:   Wed, 4 Jul 2018 08:53:05 +0200
From:   Pavel Machek <pavel@....cz>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     jacek.anaszewski@...il.com, ben.whitten@...il.com,
        geert+renesas@...der.be, w@....eu, pombredanne@...b.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v2] leds: ledtrig-morse: send out morse code

On Tue 2018-07-03 17:53:28, Andreas Klinger wrote:
> Send out a morse code by using LEDs.
> 
> This is useful especially on embedded systems without displays to tell the
> user about error conditions and status information.
> 
> The trigger will be called "morse"
> 
> The string to be send is written into the file morse_string and sent out
> with a workqueue. Supported are letters and digits.
> 
> With the file dot_unit the minimal time unit can be adjusted in
> milliseconds.
> 
> Also add documentation for the morse led trigger
> 
> Thanks to Greg and Geert for suggesting improvements
> 
> Signed-off-by: Andreas Klinger <ak@...klinger.de>

As I stated before, I don't think morse encoder belongs in kernel.

LED pattern trigger should be merged, instead.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)