linux-kernel - Re: [PATCH v2] mfd: dln2: use irqsave() in USB's complete callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Jul 2018 08:40:23 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Johan Hovold <johan@...nel.org>, Octavian Purdila <tavi@...pub.ro>,
        lkml <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH v2] mfd: dln2: use irqsave() in USB's complete callback

On Mon, 02 Jul 2018, Sebastian Andrzej Siewior wrote:

> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
> 
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Octavian Purdila <tavi@...pub.ro>
> Reviewed-by: Johan Hovold <johan@...nel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
> v1…v2: Remove also the comment that says that there is no need to
>        disable interrupts.
> 
>  drivers/mfd/dln2.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog