linux-kernel - Re: [RFC] scsi: switch to scsi-mq by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <282521f4-762c-86a5-5ac8-f8cc33b050cc@huawei.com>
Date:   Wed, 4 Jul 2018 09:18:23 +0100
From:   John Garry <john.garry@...wei.com>
To:     Bart Van Assche <Bart.VanAssche@....com>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "hch@....de" <hch@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hare@...e.de" <hare@...e.de>,
        "tom.leiming@...il.com" <tom.leiming@...il.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        chenxiang <chenxiang66@...ilicon.com>,
        Linuxarm <linuxarm@...wei.com>
Subject: Re: [RFC] scsi: switch to scsi-mq by default

On 04/07/2018 00:21, Bart Van Assche wrote:
> On Tue, 2018-07-03 at 08:54 +0200, Johannes Thumshirn wrote:
>> It has been more than one year since we tried to change the default
>> from legacy to multi queue in SCSI. Back then we had to retract the
>> change because of performance issues with rotating disks.
>>
>> In the meantime there have been a substantial amount of performance
>> improvements, thus we can re-enable scsi-mq without a significant
>> performance penalty.
>
> Hello Johannes,
>
> Please include references to commits cbe7dfa26eee ("Revert "scsi:
> default to scsi-mq"") and 5c279bd9e406 ("scsi: default to scsi-mq").
> I think it's a good idea to mention that suspend/resume now works
> with scsi-mq.
>
> Bart.

We were seeing performance drops previously for hisi_sas when originally 
enabled by default, but results on 4.18 seem almost identical with and 
without MQ default.

FWIW,

Acked-by: John Garry <john.garry@...wei.com>

>
>
>
>
>
>
>
>