linux-kernel - Re: [PATCH v4 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1530668967.17448.55.camel@mtkswgap22>
Date:   Wed, 4 Jul 2018 09:49:27 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <wsd_upstream@...iatek.com>
Subject: Re: [PATCH v4 1/5] clocksource/drivers/timer-mediatek: Add system
 timer bindings

On Tue, 2018-07-03 at 17:32 -0600, Rob Herring wrote:

Hi Rob,

> > +- reg: Should contain location and length for GPT register.
> > +- clocks: GPT is drived by system clock.
> 
> s/drived/driven/

Will be fixed in v5.

> 
> >  
> >  Examples:
> >  
> > @@ -21,5 +29,23 @@ Examples:
> >  		compatible = "mediatek,mt6577-timer";
> >  		reg = <0x10008000 0x80>;
> >  		interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
> > -		clocks = <&system_clk>, <&rtc_clk>;
> > +		clocks = <&system_clk>;
> > +	};
> > +
> > +
> > +** System Timer (SYST)
> > +
> > +Required properties:
> > +- compatible: Should contain
> > +	* "mediatek,mt6765-timer" for MT6765 compatible timers
> > +- reg: Should contain the location and length for system timer registers.
> > +- clocks: System timer is drived by system clock.
> 
> These look the same. Can't you just add the compatible string and note 
> in the description it is the system timer. Or make the compatible 
> "mediatek,mt6765-systimer"
> 

OK! We will simplify it and just use the same compatible string.

> > +
> > +Examples:
> > +
> > +	systimer@...17000 {
> 
> timer@

As above, will be fixed in v5.

> 
> > +		compatible = "mediatek,mt6765-timer";
> > +		reg = <0 0x10017000 0 0x1000>;
> > +		interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&system_clk>;
> >  	};
> > -- 
> > 1.7.9.5
> > 

Thanks.
Stanley Chu