linux-kernel - Re: [PATCH] backlight: remove obsolete comment for ->state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Jul 2018 12:05:06 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        LKML <linux-kernel@...r.kernel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Jani Nikula <jani.nikula@...el.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>
Subject: Re: [PATCH] backlight: remove obsolete comment for ->state

On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote:
> On Wed, 04 Jul 2018, Lee Jones wrote:
> 
> > > Jani spotted this when reviewing my earlier patch to remove the driver
> > > internal usage of this field in
> > > 
> > > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e
> > > Author: Daniel Vetter <daniel.vetter@...ll.ch>
> > > Date:   Wed Apr 25 19:42:52 2018 +0200
> > > 
> > >     backlight: Nuke BL_CORE_DRIVER1
> > 
> > FYI, sending patches like this is not a good idea.
> > 
> > I'll clean it up for you this time, but in future please send patches
> > properly and place any additional comments you may have below the
> > '---' line.
> 
> Ah, I see what you've tried to do.  This hurt my eyes! :)
> 
> It's more conventional to reference commits like:
> 
>   Commit 3cf91adaa594 ("backlight: Nuke BL_CORE_DRIVER1")
> 
> Again, I'll make the amendment to avoid further confusion.

So the first mail doesn't even bother to explain what's objectionable and
the 2nd mail still says "This hurts my eyes!".

Over whitespace in the commit message.

This kind of stuff is why graphics people really don't enjoy contributing
to the kernel at large. A friendly request to resend with the color choice
adjusted would go a lot further.

Thanks, Daniel

> 
> > > Cc: Jani Nikula <jani.nikula@...el.com>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
> > > Cc: Lee Jones <lee.jones@...aro.org>
> > > Cc: Daniel Thompson <daniel.thompson@...aro.org>
> > > Cc: Jingoo Han <jingoohan1@...il.com>
> > > ---
> > >  include/linux/backlight.h | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> > > index 7fbf0539e14a..0b5897446dca 100644
> > > --- a/include/linux/backlight.h
> > > +++ b/include/linux/backlight.h
> > > @@ -79,7 +79,6 @@ struct backlight_properties {
> > >  	/* Backlight type */
> > >  	enum backlight_type type;
> > >  	/* Flags used to signal drivers of state changes */
> > > -	/* Upper 4 bits are reserved for driver internal use */
> > >  	unsigned int state;
> > >  
> > >  #define BL_CORE_SUSPENDED	(1 << 0)	/* backlight is suspended */
> > 
> 
> -- 
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch