linux-kernel - Re: [PATCH V10] powercap/drivers/idle_inject: Add an idle injection framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2148928.GlOskIdrt7@aspire.rjw.lan>
Date:   Wed, 04 Jul 2018 12:49:21 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Eduardo Valentin <edubezval@...il.com>,
        Javi Merino <javi.merino@...nel.org>,
        Leo Yan <leo.yan@...aro.org>,
        Kevin Wangtao <kevin.wangtao@...aro.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rui Zhang <rui.zhang@...el.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrea Parri <andrea.parri@...rulasolutions.com>,
        "open list:POWER MANAGEMENT CORE" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH V10] powercap/drivers/idle_inject: Add an idle injection framework

On Tuesday, June 26, 2018 1:01:05 PM CEST Viresh Kumar wrote:
> On 26-06-18, 12:53, Daniel Lezcano wrote:
> > Initially, the cpu_cooling device for ARM was changed by adding a new
> > policy inserting idle cycles. The intel_powerclamp driver does a
> > similar action.
> > 
> > Instead of implementing idle injections privately in the cpu_cooling
> > device, move the idle injection code in a dedicated framework and give
> > the opportunity to other frameworks to make use of it.
> > 
> > The framework relies on the smpboot kthreads which handles via its
> > main loop the common code for hotplugging and [un]parking.
> > 
> > This code was previously tested with the cpu cooling device and went
> > through several iterations. It results now in split code and API
> > exported in the header file. It was tested with the cpu cooling device
> > with success.
> > 
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> > Cc: Viresh Kumar <viresh.kumar@...aro.org>
> > Cc: Eduardo Valentin <edubezval@...il.com>
> > Cc: Javi Merino <javi.merino@...nel.org>
> > Cc: Leo Yan <leo.yan@...aro.org>
> > Cc: Kevin Wangtao <kevin.wangtao@...aro.org>
> > Cc: Vincent Guittot <vincent.guittot@...aro.org>
> > Cc: Rui Zhang <rui.zhang@...el.com>
> > Cc: Daniel Thompson <daniel.thompson@...aro.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Andrea Parri <andrea.parri@...rulasolutions.com>
> > ---
> > 
> > V10:
> >    - Remove set_freezable (Rafael J. Wysocki)
> >    - Reduce the prefixed names 'injection' by 'inject" (Rafael J. Wysocki)
> >    - Rename 'idle_injection_wakeup_fn()' to 'idle_inject_timer_fn()' (Rafael J. Wysocki)
> >    - Shorten label 'out_rollback_per_cpu' to 'out_rollback' (Rafael J. Wysocki)
> 
> Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>

I've applied the patch, but I've rewrittent all of the comments in it.

Daniel, please check the result in linux-next and let me know if you see any
problems.

Thanks,
Rafael