[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <5B3C30AA.3070302@samsung.com>
Date: Wed, 04 Jul 2018 11:27:54 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Matthias Kaehlcke <mka@...omium.org>,
MyungJoo Ham <myungjoo.ham@...sung.com>
Cc: Kyungmin Park <kyungmin.park@...sung.com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Brian Norris <briannorris@...omium.org>,
Douglas Anderson <dianders@...omium.org>,
Enric Balletbo i Serra <enric.balletbo@...labora.com>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Viresh Kumar <viresh.kumar@...aro.org>,
Lee Jones <lee.jones@...aro.org>,
Benson Leung <bleung@...omium.org>,
Olof Johansson <olof@...om.net>
Subject: Re: [PATCH v5 03/12] PM / devfreq: Don't adjust to user limits in
governors
Hi Matthias,
On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
> Several governors use the user space limits df->min/max_freq to adjust
> the target frequency. This is not necessary, since update_devfreq()
> already takes care of this. Instead the governor can request the available
> min/max frequency by setting the target frequency to DEVFREQ_MIN/MAX_FREQ
> and let update_devfreq() take care of any adjustments.
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> Reviewed-by: Brian Norris <briannorris@...omium.org>
> ---
> Changes in v5:
> - none
>
> Changes in v4:
> - added 'Reviewed-by: Brian Norris <briannorris@...omium.org>' tag
>
> Changes in v3:
> - none
>
> Changes in v2:
> - squashed "PM / devfreq: Remove redundant frequency adjustment from governors"
> and "PM / devfreq: governors: Return device frequency limits instead of user
> limits"
> - updated subject and commit message
> - use DEVFREQ_MIN/MAX_FREQ instead of df->scaling_min/max_freq
> ---
> drivers/devfreq/governor.h | 3 +++
> drivers/devfreq/governor_performance.c | 5 +----
> drivers/devfreq/governor_powersave.c | 2 +-
> drivers/devfreq/governor_simpleondemand.c | 12 +++---------
> drivers/devfreq/governor_userspace.c | 16 ++++------------
> 5 files changed, 12 insertions(+), 26 deletions(-)
Actually, I preferred to use 'df->scaling_min/max_freq'
instead of DEVFREQ_MIN/MAX_FREQ. But, DEVFREQ_MIN/MAX_FREQ is other way.
So, Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Powered by blists - more mailing lists