linux-kernel - Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1646567c191.ed8ea5b817045.8715756414911693238@zoho.com>
Date:   Wed, 04 Jul 2018 21:07:35 +0800
From:   Huaisheng Ye <yehs2007@...o.com>
To:     "\"Jan Kara\"" <jack@...e.cz>
Cc:     <linux-nvdimm@...ts.01.org>, <dan.j.williams@...el.com>,
        <ross.zwisler@...ux.intel.com>, <mawilcox@...rosoft.com>,
        <vishal.l.verma@...el.com>, <dave.jiang@...el.com>,
        <schwidefsky@...ibm.com>, <heiko.carstens@...ibm.com>,
        <viro@...iv.linux.org.uk>, <martin.petersen@...cle.com>,
        <axboe@...nel.dk>, <gregkh@...uxfoundation.org>,
        <bart.vanassche@....com>, <jack@...e.com>, <chengnt@...ovo.com>,
        <linux-kernel@...r.kernel.org>, <linux-s390@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>,
        "\"Huaisheng Ye\"" <yehs1@...ovo.com>,
        "\"colyli\"" <colyli@...e.de>
Subject: Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access
 if useless

 ---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@...e.cz> wrote ---- 
 > On Wed 04-07-18 14:40:58, Huaisheng Ye wrote: 
 > > From: Huaisheng Ye <yehs1@...ovo.com> 
 > >  
 > > Some functions within fs/dax don't need to get gfn from direct_access. 
 > > Assigning NULL to gfn of dax_direct_access is more intuitive and simple 
 > > than offering a useless local variable. 
 > >  
 > > Signed-off-by: Huaisheng Ye <yehs1@...ovo.com> 
 >  
 > I like this. You can add: 
 >  
 > Reviewed-by: Jan Kara <jack@...e.cz> 
 >  
 > for the series. 
 >  
 >                                 Honza 
 >  
I am so happy you like them, thank you very much.

---
Cheers,
Huaisheng