linux-kernel - Re: [PATCH 4/5] iio: adc: ti_am335x_adc: Disable ADC during suspend unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f639cd3f-ff67-c748-8768-cff05eb11305@ti.com>
Date:   Wed, 4 Jul 2018 20:10:46 +0530
From:   Vignesh R <vigneshr@...com>
To:     Jonathan Cameron <jic23@...nel.org>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH 4/5] iio: adc: ti_am335x_adc: Disable ADC during suspend
 unconditionally



On Saturday 30 June 2018 08:48 PM, Jonathan Cameron wrote:
> On Sat, 30 Jun 2018 16:03:17 +0530
> Vignesh R <vigneshr@...com> wrote:
> 
>> Parent MFD device takes care of enabling ADC interface whenever
>> touchscreen is marked wakeup capable. Therefore, unconditionally disable
>> ADC interface during system suspend to save power in case of system with
>> just ADC and no TSC.
>>
>> Signed-off-by: Vignesh R <vigneshr@...com>
> 
> This sounds like a sensible change to me.   Is it applicable without the
> rest of the series?  If so I'll take it through IIO.  If the answer
> is that it needs to go with the rest then
> 

This patch as such does not have any compile time dependencies on other
patches, but I would like Dmitry's opinion on the series before being
merged.

> Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 

Thanks!


Regards
Vignesh

> Thanks,
> 
> Jonathan
>> ---
>>  drivers/iio/adc/ti_am335x_adc.c | 12 ++++--------
>>  1 file changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>> index 80df5a377d30..cafb1dcadc48 100644
>> --- a/drivers/iio/adc/ti_am335x_adc.c
>> +++ b/drivers/iio/adc/ti_am335x_adc.c
>> @@ -693,16 +693,12 @@ static int __maybe_unused tiadc_suspend(struct device *dev)
>>  {
>>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>  	struct tiadc_device *adc_dev = iio_priv(indio_dev);
>> -	struct ti_tscadc_dev *tscadc_dev;
>>  	unsigned int idle;
>>  
>> -	tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
>> -	if (!device_may_wakeup(tscadc_dev->dev)) {
>> -		idle = tiadc_readl(adc_dev, REG_CTRL);
>> -		idle &= ~(CNTRLREG_TSCSSENB);
>> -		tiadc_writel(adc_dev, REG_CTRL, (idle |
>> -				CNTRLREG_POWERDOWN));
>> -	}
>> +	idle = tiadc_readl(adc_dev, REG_CTRL);
>> +	idle &= ~(CNTRLREG_TSCSSENB);
>> +	tiadc_writel(adc_dev, REG_CTRL, (idle |
>> +			CNTRLREG_POWERDOWN));
>>  
>>  	return 0;
>>  }
> 

-- 
Regards
Vignesh