linux-kernel - Re: [PATCH 3/3] kvm: add a function to check if page is from NVDIMM pmem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe420914-212f-a18e-b6ec-f2b7a451c0d2@redhat.com>
Date:   Wed, 4 Jul 2018 17:27:17 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Dan Williams <dan.j.williams@...el.com>,
        Zhang Yi <yi.z.zhang@...ux.intel.com>
Cc:     KVM list <kvm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@....de>,
        "Zhang, Yu C" <yu.c.zhang@...el.com>,
        Linux MM <linux-mm@...ck.org>, rkrcmar@...hat.com,
        "Zhang, Yi Z" <yi.z.zhang@...el.com>,
        Jérôme Glisse <jglisse@...hat.com>
Subject: Re: [PATCH 3/3] kvm: add a function to check if page is from NVDIMM
 pmem.

On 04/07/2018 16:50, Dan Williams wrote:
>> +       return is_zone_device_page(page) &&
>> +               ((page->pgmap->type == MEMORY_DEVICE_FS_DAX) ||
>> +                (page->pgmap->type == MEMORY_DEVICE_DEV_DAX));
> Jerome, might there be any use case to pass MEMORY_DEVICE_PUBLIC
> memory to a guest vm?
> 

An even better reason to place this in mm.h. :)  There should be an
function to tell you if a reserved page has accessed/dirty bits etc.,
that's all that KVM needs to know.

Paolo