lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Jul 2018 15:55:10 +0000 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Colin King <colin.king@...onical.com> Cc: Ravi Chandra Sadineni <ravisadineni@...omium.org>, linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Input: cros_ec_keyb: remove redundant variable num_cols On Mon, Jul 02, 2018 at 05:28:41PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Variable num_cols is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable ‘num_cols’ set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.king@...onical.com> Applied, thank you. > --- > drivers/input/keyboard/cros_ec_keyb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > index 820bebad519a..81be6f781f0b 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -160,9 +160,6 @@ static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev, > int col, row; > int new_state; > int old_state; > - int num_cols; > - > - num_cols = len; > > if (ckdev->ghost_filter && cros_ec_keyb_has_ghosting(ckdev, kb_state)) { > /* > -- > 2.17.1 > -- Dmitry
Powered by blists - more mailing lists