[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANc+2y7BU5SmgP8yv46PQx2E1Bz1gb0dOQaM0wG=-iReCd8YyQ@mail.gmail.com>
Date: Wed, 4 Jul 2018 22:30:43 +0530
From: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
To: Paul Cercueil <paul@...pouillou.net>
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Ralf Baechle <ralf@...ux-mips.org>,
Paul Burton <paul.burton@...s.com>,
James Hogan <jhogan@...nel.org>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
Mathieu Malaterre <malat@...ian.org>,
Daniel Silsby <dansilsby@...il.com>, dmaengine@...r.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
Linux-MIPS <linux-mips@...ux-mips.org>
Subject: Re: [PATCH 07/14] dmaengine: dma-jz4780: Enable Fast DMA to the AIC
On 3 July 2018 at 18:02, Paul Cercueil <paul@...pouillou.net> wrote:
> With the fast DMA bit set, the DMA will transfer twice as much data
> per clock period to the AIC, so there is little point not to set it.
>
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
> drivers/dma/dma-jz4780.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index 922e4031e70e..7ee2c121948f 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -52,6 +52,7 @@
> #define JZ_DMA_DMAC_DMAE BIT(0)
> #define JZ_DMA_DMAC_AR BIT(2)
> #define JZ_DMA_DMAC_HLT BIT(3)
> +#define JZ_DMA_DMAC_FAIC BIT(27)
> #define JZ_DMA_DMAC_FMSC BIT(31)
>
> #define JZ_DMA_DRT_AUTO 0x8
> @@ -929,8 +930,8 @@ static int jz4780_dma_probe(struct platform_device *pdev)
> * Also set the FMSC bit - it increases MSC performance, so it makes
> * little sense not to enable it.
> */
> - jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DMAC,
> - JZ_DMA_DMAC_DMAE | JZ_DMA_DMAC_FMSC);
> + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DMAC, JZ_DMA_DMAC_DMAE |
> + JZ_DMA_DMAC_FAIC | JZ_DMA_DMAC_FMSC);
>
> if (jzdma->version == ID_JZ4780)
> jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DMACP, 0);
> --
> 2.18.0
>
>
Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>.
Powered by blists - more mailing lists