linux-kernel - Re: [PATCH] tipc: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c9bd75f-a3e4-79fd-b7e7-79aeb42fbb50@windriver.com>
Date:   Thu, 5 Jul 2018 13:57:02 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Jon Maloy <jon.maloy@...csson.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tipc: mark expected switch fall-throughs

On 07/05/2018 05:13 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Warning level 2 was used: -Wimplicit-fallthrough=2
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/bearer.c | 1 +
>  net/tipc/link.c   | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index 2dfb492..fd6d8f1 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -610,6 +610,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
>  	case NETDEV_CHANGE:
>  		if (netif_carrier_ok(dev))
>  			break;
> +		/* else: fall through */
>  	case NETDEV_UP:
>  		test_and_set_bit_lock(0, &b->up);
>  		break;
> diff --git a/net/tipc/link.c b/net/tipc/link.c
> index 695acb7..6386032 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -1063,6 +1063,7 @@ static bool tipc_data_input(struct tipc_link *l, struct sk_buff *skb,
>  			skb_queue_tail(mc_inputq, skb);
>  			return true;
>  		}
> +		/* else: fall through */
>  	case CONN_MANAGER:
>  		skb_queue_tail(inputq, skb);
>  		return true;
>