linux-kernel - RE: [PATCH] Use short unix-style option instead of --longname.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c2a4e820664c43a29d006153e5043c@SOC-EX01V.e01.socionext.com>
Date:   Thu, 5 Jul 2018 02:05:33 +0000
From:   <yamada.masahiro@...ionext.com>
To:     <rob@...dley.net>, <trivial@...nel.org>, <keescook@...omium.org>,
        <ulfalizer@...il.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Use short unix-style option instead of --longname.

Hi.

> -----Original Message-----
> From: Rob Landley [mailto:rob@...dley.net]
> Sent: Thursday, July 05, 2018 4:06 AM
> To: trivial@...nel.org; Yamada, Masahiro/山田 真弘
> <yamada.masahiro@...ionext.com>; Kees Cook <keescook@...omium.org>; Ulf
> Magnusson <ulfalizer@...il.com>
> Subject: [PATCH] Use short unix-style option instead of --longname.
> 
> From: Rob Landley <rob@...dley.net>
> 
> Use short unix-style option instead of --longname.

This is the repeat of the subject.
Instead, could you describe the reason of this patch here please?


> Signed-off-by: Rob Landley <rob@...dley.net>
> ---
> 
> Avoids warning messages with the latest release of toybox, which never
> bothered
> to implement the --longopts nothing was using.

I am fine with this patch,
but I want the information below the --- line
to be recorded in git.


I think WHY is the most important part in the commit log.

If the commit log only mentions 'Use short unix-style option instead of --longname'
it is not easy to know why this commit is necessary.





>  init/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 041f3a0..192d400 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -2,9 +2,9 @@ config DEFCONFIG_LIST
>  	string
>  	depends on !UML
>  	option defconfig_list
> -	default "/lib/modules/$(shell,uname --release)/.config"
> +	default "/lib/modules/$(shell,uname -r)/.config"
>  	default "/etc/kernel-config"
> -	default "/boot/config-$(shell,uname --release)"
> +	default "/boot/config-$(shell,uname -r)"
>  	default ARCH_DEFCONFIG
>  	default "arch/$(ARCH)/defconfig"