linux-kernel - Re: [PATCH v2 0/3] m68k: switch to MEMBLOCK + NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Jul 2018 22:13:52 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Sam Creasey <sammy@...my.net>
Cc:     Michal Hocko <mhocko@...nel.org>, linux-m68k@...ts.linux-m68k.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] m68k: switch to MEMBLOCK + NO_BOOTMEM

Hi Mike,

On 04/07/18 16:28, Mike Rapoport wrote:
> These patches switch m68k boot time memory allocators from bootmem to
> memblock + no_bootmem.
> 
> The first two patches update __ffs() and __va() definitions to be inline
> with other arches and asm-generic. This is required to avoid compilation
> warnings in mm/memblock.c and mm/nobootmem.c.
> 
> The third patch performs the actual switch of the boot time mm. Its
> changelog has detailed description of the changes.
> 
> I've tested the !MMU version with qemu-system-m68k -M mcf5208evb
> and the MMU version with q800 using qemu from [1].
> 
> I've also build tested allyesconfig and *_defconfig.
> 
> [1] https://github.com/vivier/qemu-m68k.git
> 
> v2:
> * fix reservation of the kernel text/data/bss for ColdFire MMU

I am happy with all of these, so for me:

Acked-by: Greg Ungerer <gerg@...ux-m68k.org>

Regards
Greg



> Mike Rapoport (3):
>    m68k/bitops: convert __ffs to match generic declaration
>    m68k/page_no.h: force __va argument to be unsigned long
>    m68k: switch to MEMBLOCK + NO_BOOTMEM
> 
>   arch/m68k/Kconfig               |  3 +++
>   arch/m68k/include/asm/bitops.h  |  8 ++++++--
>   arch/m68k/include/asm/page_no.h |  2 +-
>   arch/m68k/kernel/setup_mm.c     | 14 ++++----------
>   arch/m68k/kernel/setup_no.c     | 20 ++++----------------
>   arch/m68k/mm/init.c             |  1 -
>   arch/m68k/mm/mcfmmu.c           | 13 +++++++------
>   arch/m68k/mm/motorola.c         | 35 +++++++++++------------------------
>   arch/m68k/sun3/config.c         |  4 ----
>   9 files changed, 36 insertions(+), 64 deletions(-)
>