linux-kernel - Re: [PATCH v11 1/2] Refactor part of the oom report in dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vecv43Q6_LPaLd4YR3OowVKgpR7YJe2Od2Hj_KU7=kEGw@mail.gmail.com>
Date:   Thu, 5 Jul 2018 15:24:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     禹舟键 <ufo19890607@...il.com>
Cc:     mhocko@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
        David Rientjes <rientjes@...gle.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        aarcange@...hat.com,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, guro@...com,
        yang.s@...baba-inc.com, linux-mm <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wind Yu <yuzhoujian@...ichuxing.com>
Subject: Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

On Thu, Jul 5, 2018 at 2:23 PM, 禹舟键 <ufo19890607@...il.com> wrote:
> Hi Michal and Andy

> The enum oom_constraint  will be added in the struct oom_control.  So
> I still think I should define it in oom.h.

You missed the point. I'm talking about an array of string literals.
Please, check what the warning I got from the compiler.

> Michal Hocko <mhocko@...nel.org> 于2018年7月4日周三 下午4:17写道：
>>
>> On Wed 04-07-18 10:25:30, 禹舟键 wrote:
>> > Hi Andy
>> > The const char array need to be used by the new func
>> > mem_cgroup_print_oom_context and some funcs in oom_kill.c in the
>> > second patch.
>>
>> Just declare it in oom.h and define in oom.c
>> --
>> Michal Hocko
>> SUSE Labs



-- 
With Best Regards,
Andy Shevchenko