linux-kernel - Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a17d4761-411e-020b-4bd6-b091eec3964f@redhat.com>
Date:   Thu, 5 Jul 2018 14:41:25 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     "Raslan, KarimAllah" <karahmed@...zon.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Cc:     "rkrcmar@...hat.com" <rkrcmar@...hat.com>
Subject: Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 05/07/2018 14:22, Raslan, KarimAllah wrote:
>> They don't support atomics on double-word data.
> But they support atomics on single words. Of which there are two.
> We don't need atomic updates of the whole 64-bit quantity (a là 
> cmpxchg). Do we strictly need this to be atomic accross the 64-bit?
> 
> Looking at the use cases for "requests":
> 
> kvm_clear_request
> kvm_test_request
> kvm_request_pending
> kvm_check_request
> 
> ... and all of them would still work if the atomicity is only at the 
> word level, right?
> 

Good point!  Then yes, requests can be made 64 bit wide.

Paolo