[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180705154758.GA112168@atomide.com>
Date: Thu, 5 Jul 2018 08:47:58 -0700
From: Tony Lindgren <tony@...mide.com>
To: Faiz Abbas <faiz_abbas@...com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-clk@...r.kernel.org, robh+dt@...nel.org,
bcousson@...libre.com, paul@...an.com, t-kristo@...com,
mark.rutland@....com
Subject: Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset
* Faiz Abbas <faiz_abbas@...com> [180705 14:24]:
> +static int sysc_reset(struct sysc *ddata)
> +{
> + int offset = ddata->offsets[SYSC_SYSCONFIG];
> + int val = sysc_read(ddata, offset);
Can you please just warn and return early for now if no
syss_mask is specified? Otherwise we'll have mysterious
errors if somebody leaves out "ti,hwmods" for module types
we do not yet support reset for.
> + val |= (0x1 << ddata->cap->regbits->srst_shift);
> + sysc_write(ddata, offset, val);
> +
> + /* Poll on reset status */
> + if (ddata->cfg.syss_mask) {
> + offset = ddata->offsets[SYSC_SYSSTATUS];
> +
> + return readl_poll_timeout(ddata->module_va + offset, val,
> + (val & ddata->cfg.syss_mask) == 0x0,
> + 100, MAX_MODULE_SOFTRESET_WAIT);
> + }
> +
> + return 0;
> +}
> +
Otherwise looks good to me.
Thanks,
Tony
Powered by blists - more mailing lists