[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180705165526.GA4349@kroah.com>
Date: Thu, 5 Jul 2018 18:55:26 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc: Keith Busch <keith.busch@...el.com>,
Jianchao Wang <jianchao.w.wang@...cle.com>,
stable@...r.kernel.org,
Sasha Levin <alexander.levin@...rosoft.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.4] nvme-pci: initialize queue memory before interrupts
On Tue, Jun 19, 2018 at 06:23:06PM +0100, Ben Hutchings wrote:
> From: Keith Busch <keith.busch@...el.com>
>
> commit 161b8be2bd6abad250d4b3f674bdd5480f15beeb upstream.
>
> A spurious interrupt before the nvme driver has initialized the completion
> queue may inadvertently cause the driver to believe it has a completion
> to process. This may result in a NULL dereference since the nvmeq's tags
> are not set at this point.
>
> The patch initializes the host's CQ memory so that a spurious interrupt
> isn't mistaken for a real completion.
>
> Signed-off-by: Keith Busch <keith.busch@...el.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
> Signed-off-by: Christoph Hellwig <hch@....de>
> [bwh: Backported to 4.4: adjust context]
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> ---
> drivers/nvme/host/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Now applied, thanks.
greg k-h
Powered by blists - more mailing lists