linux-kernel - Re: [PATCH 2/4] scsi: bfa: remove ScsiResult macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f5d6a4266daabfd49bad726f17524d80fdab524.camel@wdc.com>
Date:   Thu, 5 Jul 2018 17:00:10 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] scsi: bfa: remove ScsiResult macro

On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote:
> -	cmnd->result = ScsiResult(DID_OK, SCSI_STATUS_GOOD);
> +	cmnd->result = DID_OK << 16 | SCSI_STATUS_GOOD;

Please consider to remove the SCSI_STATUS_GOOD constant since it is
non-standard and since it used by the bfa driver only. Additionally, since
SCSI_STATUS_GOOD == 0, please leave out "| SCSI_STATUS_GOOD".

Thanks,

Bart.