linux-kernel - RE: [PATCH 1/6] efi: Introduce efi_memmap_free() to free memory allocated by efi_memmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <FFF73D592F13FD46B8700F0A279B802F4659B195@ORSMSX111.amr.corp.intel.com>
Date:   Thu, 5 Jul 2018 18:30:33 +0000
From:   "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@...el.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
CC:     linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lee Chun-Yi <jlee@...e.com>, Dave Young <dyoung@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Laszlo Ersek <lersek@...hat.com>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Nicolai Stange <nicstange@...il.com>,
        Naresh Bhat <naresh.bhat@...aro.org>,
        "Neri, Ricardo" <ricardo.neri@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Taku Izumi <izumi.taku@...fujitsu.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        "Williams, Dan J" <dan.j.williams@...el.com>
Subject: RE: [PATCH 1/6] efi: Introduce efi_memmap_free() to free memory
 allocated by efi_memmap_alloc()

> > Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>
> > Suggested-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > Cc: Lee Chun-Yi <jlee@...e.com>
> > Cc: Dave Young <dyoung@...hat.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Laszlo Ersek <lersek@...hat.com>
> > Cc: Jan Kiszka <jan.kiszka@...mens.com>
> > Cc: Dave Hansen <dave.hansen@...el.com>
> > Cc: Bhupesh Sharma <bhsharma@...hat.com>
> > Cc: Nicolai Stange <nicstange@...il.com>
> > Cc: Naresh Bhat <naresh.bhat@...aro.org>
> > Cc: Ricardo Neri <ricardo.neri@...el.com>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Taku Izumi <izumi.taku@...fujitsu.com>
> > Cc: Ravi Shankar <ravi.v.shankar@...el.com>
> > Cc: Matt Fleming <matt@...eblueprint.co.uk>
> > Cc: Dan Williams <dan.j.williams@...el.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> 
> Do you really think you should cc all these people?
> 

Sorry! I get that..

> > ---
> >  drivers/firmware/efi/memmap.c | 28 ++++++++++++++++++++++++++++
> >  include/linux/efi.h           |  8 ++++++++
> >  2 files changed, 36 insertions(+)
> >

[snip]

> I am now thinking we should perhaps hide the allocation type from the callers
> rather than passing around implementation details of the allocator, and have
> explicit alloc/free operations.
> 
> Could we instead have a single 'efi_realloc_memmap()' function that takes care
> of all of this?

Sure! I will give it a try.

Regards,
Sai