linux-kernel - Re: [PATCH] sample/vfio-mdev: Change return type to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jul 2018 13:44:32 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     willy@...radead.org, kwankhede@...dia.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, svptas.linux@...il.com,
        brajeswar.linux@...il.com, sabyasachi.linux@...il.com,
        ajitn.linux@...il.com
Subject: Re: [PATCH] sample/vfio-mdev: Change return type to vm_fault_t

On Wed, 4 Jul 2018 21:00:14 +0530
Souptick Joarder <jrdr.linux@...il.com> wrote:

> convert mbochs_region_vm_fault and mbochs_dmabuf_vm_fault
> to return vm_fault_t type.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
>  samples/vfio-mdev/mbochs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
> index 2960e26..7743fbc 100644
> --- a/samples/vfio-mdev/mbochs.c
> +++ b/samples/vfio-mdev/mbochs.c
> @@ -657,7 +657,7 @@ static void mbochs_put_pages(struct mdev_state *mdev_state)
>  	dev_dbg(dev, "%s: %d pages released\n", __func__, count);
>  }
>  
> -static int mbochs_region_vm_fault(struct vm_fault *vmf)
> +static vm_fault_t mbochs_region_vm_fault(struct vm_fault *vmf)
>  {
>  	struct vm_area_struct *vma = vmf->vma;
>  	struct mdev_state *mdev_state = vma->vm_private_data;
> @@ -695,7 +695,7 @@ static int mbochs_mmap(struct mdev_device *mdev, struct vm_area_struct *vma)
>  	return 0;
>  }
>  
> -static int mbochs_dmabuf_vm_fault(struct vm_fault *vmf)
> +static vm_fault_t mbochs_dmabuf_vm_fault(struct vm_fault *vmf)
>  {
>  	struct vm_area_struct *vma = vmf->vma;
>  	struct mbochs_dmabuf *dmabuf = vma->vm_private_data;


Looks good to me, I'll include this in my vfio for-linus branch for
v4.18. Thanks,

Alex