linux-kernel - Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180706113114.sm5ntnoxozp3xo67@earth.universe>
Date:   Fri, 6 Jul 2018 13:31:14 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Brian Norris <briannorris@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        Rhyland Klein <rklein@...dia.com>,
        Alexandru Stan <amstan@...omium.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Doug Anderson <dianders@...omium.org>,
        Phil Reid <preid@...ctromag.com.au>
Subject: Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document
 "ti,bq20z75"

Hi,

On Tue, Jun 12, 2018 at 01:20:42PM -0700, Brian Norris wrote:
> This compatible property was documented before the driver was renamed to
> "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate
> bq20z75->sbs rename to dt bindings")). The driver has continued to
> support this property as an alternative to "sbs,sbs-battery", and
> because we've noticed there are some lingering TI specifics (in the
> manufacturer-specific portion of the SBS spec), we'd like to start using
> this property again to differentiate.
> 
> In typical DT fashion, the <vendor>,<part-number> specifics should be
> used ahead of the generic "sbs,sbs-battery" string, so we can handle
> vendor specifics -- so document this. Language borrowed mostly from
> Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt
> 
> Also fixup the example to use this property (it's already implying that
> it's "bq20z75@b"); fixup the node name to be generic ("battery", not
> "<part-number>"); and fixup some whitespace.
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Acked-by: Rhyland Klein <rklein@...dia.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---

Thanks, queued to power-supply-next.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)