linux-kernel - [PATCH] vsprintf: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  6 Jul 2018 15:47:08 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Tobin C. Harding" <me@...in.cc>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        "Theodore Ts'o" <tytso@....edu>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: [PATCH] vsprintf: fix build warning

The have_filled_random_ptr_key variable was recently removed,
but then reappeared with another patch, presumably after an
incorrect rebase:

lib/vsprintf.c:1668:13: error: 'have_filled_random_ptr_key' defined but not used [-Werror=unused-variable]

This removes it again.

Fixes: 85f4f12d5139 ("vsprintf: Replace memory barrier with static_key for random_ptr_key update")
Fixes: bfe80ed3d7c7 ("vsprintf: add command line option debug_boot_weak_hash")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 lib/vsprintf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index cdc2c355dff5..5fe18ac4d37c 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1665,7 +1665,6 @@ static int __init debug_boot_weak_hash_enable(char *str)
 }
 early_param("debug_boot_weak_hash", debug_boot_weak_hash_enable);
 
-static bool have_filled_random_ptr_key __read_mostly;
 static siphash_key_t ptr_key __read_mostly;
 
 static void enable_ptr_key_workfn(struct work_struct *work)
-- 
2.9.0