linux-kernel - Re: [PATCH] media: stm32: dcmi: replace "%p" with "%pK"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64b2a2ea-2da9-c40d-eae4-6375079771e7@xs4all.nl>
Date:   Fri, 6 Jul 2018 15:51:07 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        mchehab@...nel.org, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, hans.verkuil@...co.com,
        hugues.fruchet@...com
Cc:     linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH] media: stm32: dcmi: replace "%p" with "%pK"

On 06/07/18 15:03, Benjamin Gaignard wrote:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.

This patch no longer applies. AFAICT it is obsolete after some code reorg.

Regards,

	Hans

> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
> ---
>  drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 2e1933d872ee..fe90672cf16f 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)
>  
>  	ret = clk_prepare(mclk);
>  	if (ret) {
> -		dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
> +		dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
>  		goto err_dma_release;
>  	}
>  
>